TreeView: Fix focus styles in styled-components v5.2+ #2375
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
styled-components v5.2 introduced a bug that changed how it expands
&
in CSS selectors.This bug affected TreeView's current and focused styles (see "before" pictures).
Solution
I had to get creative with our CSS selectors to work around this bug.
Screenshots
Closes https://github.com/github/primer/issues/1312
Merge checklist
Added/updated testsAdded/updated documentationTake a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.