TreeView: Increase touch target size for coarse pointers #2376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 151ce1a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
size-limit report 📦
|
colebemis
changed the title
cursor:coarse
colebemis
changed the title
cursor:coarsepointer:coarse
colebemis
changed the title
pointer:coarse
broccolinisoup
approved these changes
Sep 27, 2022
| fontSize: 1, | ||
| color: 'fg.default', | ||
| borderRadius: 2, | ||
| cursor: 'pointer', | ||
| '&:hover': { | ||
| backgroundColor: 'actionListItem.default.hoverBg' | ||
| }, | ||
| '@media (pointer: coarse)': { | ||
| '--toggle-width': '1.5rem', // 24px |
There was a problem hiding this comment.
Nice! Is there a specific value for min touch target size in the guideline? Because I increased the touch target size on the UnderlineNav as well but used the value from design. I am curious to see if there is a guideline
There was a problem hiding this comment.
Not sure. @mperrotti might know!
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Increases the touch target size of tree items when the device pointer has limited accuracy (example: touch screen devices).
Screenshots
pointer:finepointer:coarseMerge checklist
Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.