fix(bundle): update files field for npm package #2391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 1aea651 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
joshblack
changed the title
joshblack
changed the title
size-limit report 📦
|
colebemis
approved these changes
Oct 1, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
lib/node_modulesto thefilesarray inpackage.json. By default, folders namednode_modulesare (understandably) not included during publish. This folder is now explicitly included. A quick test withnpm publish --dry-runlists this folder and its files in the package tarballContext
The
node_modulesfolder here is only present for CommonJS and is for dependencies which are ESM-only. This is a current trade-off to allow the CommonJS bundle to work until PRC is able to move to an ESM-only package. This does not impact the ESM path for PRC.