TreeView: Improve accessibility of async items #2429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: b1b0766 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
size-limit report 📦
|
colebemis
requested review from
joshblack and
ericwbailey
and removed request for
rezrah
joshblack
approved these changes
Oct 13, 2022
| // Show loading indicator after a short delay | ||
| React.useEffect(() => { | ||
| if (state === 'loading') { | ||
| timeoutId.current = safeSetTimeout(() => { |
There was a problem hiding this comment.
It seems like since we're having to manually manage the timer that we could use setTimeout and clearTimeout directly. Is there something that safeSetTimeout is doing here that's nice to have?
There was a problem hiding this comment.
I think safeSetTimeout is a thin wrapper around setTimeout to make sure all timeouts get cleaned up when a component unmounts. Not sure if there are downsides to using safeSetTimeout here instead of setTimeout directly
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing a11y feedback from https://github.com/github/primer/issues/815#issuecomment-1273922579
👉 Try it out
Changes
aria-liveregion (based on @ericwbailey's guidance)stateprop toTreeView.SubTreeto support thearia-liveregion implementationCleanShot.2022-10-12.at.19.21.59.mp4
Merge checklist
Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.