Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move SplitPageLayout from drafts to alpha #2435

Merged
merged 4 commits into from
Oct 14, 2022
Merged

Conversation

colebemis
Copy link
Contributor

SplitPageLayout has been signed off by the accessibility team and is ready to be moved to alpha status. This PR updates the SplitPageLayout docs and exports SplitPageLayout from the main @primer/react bundle.

Before After
import {SplitPageLayout} from '@primer/react/drafts import {SplitPageLayout} from '@primer/react'

@changeset-bot
Copy link

changeset-bot bot commented Oct 14, 2022

🦋 Changeset detected

Latest commit: cf247c0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@colebemis colebemis marked this pull request as ready for review October 14, 2022 21:33
@colebemis colebemis requested review from a team and pksjce October 14, 2022 21:33
@github-actions
Copy link
Contributor

github-actions bot commented Oct 14, 2022

size-limit report 📦

Path Size
dist/browser.esm.js 77.93 KB (+0.34% 🔺)
dist/browser.umd.js 78.58 KB (+0.31% 🔺)

@@ -5,6 +5,7 @@ status: Alpha
# description: TODO
source: https://github.com/primer/react/tree/main/src/PageLayout
storybook: https://primer.style/react/storybook?path=/story/layout-pagelayout--default
a11yReviewed: true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💖 thank you for remembering to add this in! I have a PR open to add a task in the issue template as a reminder.

@colebemis colebemis temporarily deployed to github-pages October 14, 2022 21:42 Inactive
@colebemis colebemis merged commit e335cc4 into main Oct 14, 2022
@colebemis colebemis deleted the split-page-layout-alpha branch October 14, 2022 21:52
@primer-css primer-css mentioned this pull request Oct 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants