Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TreeView: Use correct design tokens and icons #2446

Merged
merged 6 commits into from Oct 18, 2022
Merged

TreeView: Use correct design tokens and icons #2446

merged 6 commits into from Oct 18, 2022

Conversation

colebemis
Copy link
Contributor

@colebemis colebemis commented Oct 17, 2022 •
edited

  • Updates the color of TreeView.DirectoryIcon to use treeViewItem.directory.fill variable
  • Updates the color of the hover background on chevrons to use treeViewItem.chevron.hoverBg
  • Updates the chevron icon to the 12px version instead of 16px
Before After
CleanShot 2022-10-17 at 16 54 43@2x CleanShot 2022-10-17 at 16 52 22@2x

@changeset-bot
Copy link

changeset-bot bot commented Oct 17, 2022 •
edited

🦋 Changeset detected

Latest commit: 0646e39

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Oct 17, 2022 •
edited

size-limit report 📦

Path Size
dist/browser.esm.js 77.99 KB (+0.12% 🔺)
dist/browser.umd.js 78.64 KB (+0.12% 🔺)

@colebemis colebemis marked this pull request as ready for review October 17, 2022 23:55
@colebemis colebemis requested a review from a team October 17, 2022 23:55
@colebemis colebemis temporarily deployed to github-pages October 18, 2022 00:01 Inactive
broccolinisoup
broccolinisoup approved these changes Oct 18, 2022
View reviewed changes
Copy link
Member

@broccolinisoup broccolinisoup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good ✨

@colebemis colebemis temporarily deployed to github-pages October 18, 2022 21:56 Inactive
@colebemis colebemis merged commit e00d03c into main Oct 18, 2022
@colebemis colebemis deleted the treeview-tokens-icons branch October 18, 2022 21:59
@primer-css primer-css mentioned this pull request Oct 18, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@broccolinisoup broccolinisoup broccolinisoup approved these changes

@mperrotti mperrotti Awaiting requested review from mperrotti

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@colebemis @broccolinisoup