Update useLinkInterception to fix clickHandler #2493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 275189a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
size-limit report 📦
|
joshblack
approved these changes
Oct 31, 2022
|
@joshblack Thanks for the review! Anything I need to do from my side to push the UI Tests along? |
|
@nicolleromero you should be good! Our Chromatic plan seems to have hit it's limit so it's currently staying as pending 😞 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates
useLinkInterceptionin theMarkdownViewerto prevent a bug that was causingonLinkClickto not be called when the DOM was updated with new links without the React component rerendering (such as when using custom web components and converting a draft into an issue –– see BEFORE screenshot).Closes # https://github.com/github/issues-graph/issues/812
Screenshots
BEFORE
Tasklist.link.after.convert.bug.mov
AFTER
Tasklist.links.fix.mov
Merge checklist
Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.