Remove deprecated focus style primitives #2510
Conversation
🦋 Changeset detectedLatest commit: ec35a70 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
size-limit report 📦
|
…rimer/react into remove-deprecated-focus-styles
|
@langermank random question, would there be a good way to pull out common styles (like for focus in this PR and defined in https://github.com/github/primer/issues/409) into a common module to apply to components when we need them? Similar to helper classes, mixins, or functions but with styled-components. |
@joshblack I think ideally we would put global focus styles in this file and then create some shared "mixins" so we can have custom focus style overrides for components. This is what we've done in PCSS. To be honest I'm not totally sure what the state of focus styles is in PRC, as I bet we are actually seeing focus styles in memex coming from PCSS. In that BaseStyles file, its removing |
|
@joshblack I just stumbled upon this: https://github.com/primer/react/blob/main/src/_getGlobalFocusStyles.ts |
* remove deprecated primitives * Create afraid-wombats-drive.md * snippy snaps * move to draft directory * fix focus color * test: update snapshots Co-authored-by: Josh Black <josh@josh.black>
Describe your changes here.
Removing old/unused focus style CSS vars so we can deprecate them from
primer/primitivesScreenshots
Please provide before/after screenshots for any visual changes
Merge checklist
Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.