Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Storybook preview deploy button to PRs #2567

Merged
merged 4 commits into from
Nov 10, 2022
Merged

Add Storybook preview deploy button to PRs #2567

merged 4 commits into from
Nov 10, 2022

Conversation

langermank
Copy link
Contributor

@langermank langermank commented Nov 10, 2022 •
edited

Co-authored-by: Josh Black joshblack@users.noreply.github.com

Adds a Deploy preview button to PRs for Storybook ✨

Merge checklist

  • Added/updated tests
  • Added/updated documentation
  • Tested in Chrome
  • Tested in Firefox
  • Tested in Safari
  • Tested in Edge

Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.

@langermank @joshblack
add deploy workflow
d584ac0 
Co-authored-by: Josh Black <joshblack@users.noreply.github.com>
@changeset-bot
Copy link

changeset-bot bot commented Nov 10, 2022 •
edited

⚠️ No Changeset found

Latest commit: 1a432ae

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Nov 10, 2022 •
edited

size-limit report 📦

Path Size
dist/browser.esm.js 78.9 KB (0%)
dist/browser.umd.js 79.54 KB (0%)

@langermank langermank temporarily deployed to github-pages November 10, 2022 21:29 Inactive
@langermank langermank temporarily deployed to github-pages November 10, 2022 21:38 Inactive
@github-actions github-actions bot temporarily deployed to Storybook Preview November 10, 2022 21:38 Inactive
@langermank langermank changed the title Test Add Storybook preview deploy button to PRs Nov 10, 2022
@joshblack joshblack added the skip changeset This change does not need a changelog label Nov 10, 2022
@langermank langermank marked this pull request as ready for review November 10, 2022 21:46
@langermank langermank requested review from a team and mperrotti November 10, 2022 21:46
@github-actions github-actions bot temporarily deployed to Storybook Preview (2567) November 10, 2022 21:50 Inactive
@langermank langermank temporarily deployed to github-pages November 10, 2022 21:50 Inactive
joshblack
joshblack approved these changes Nov 10, 2022
View reviewed changes
Copy link
Member

@joshblack joshblack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳

@langermank langermank merged commit 9cb14fe into main Nov 10, 2022
@langermank langermank deleted the storybook-deploy-button branch November 10, 2022 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshblack joshblack joshblack approved these changes

@mperrotti mperrotti Awaiting requested review from mperrotti

Assignees
No one assigned
Labels
skip changeset This change does not need a changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@langermank @joshblack