Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add back Primer CSS build and instructions for using it #260

Merged
merged 55 commits into from Sep 20, 2018

Conversation

shawnbot
Copy link
Contributor

@shawnbot shawnbot commented Sep 14, 2018

Fixes #124. I went back and forth on whether to include an actual React component for including the CSS, and after thrashing on bundling the CSS at build time a bit I settled on simply building dist/primer-components.css and documenting a couple of ways to import that file into various flavors of app.

The rendered README section has usage instructions; let me know if they don't make sense!

While I was in there, I revived server-side rendering of the styled-components CSS, so all of the styles should be available before any content is loaded on the site unless they're rendered only client-side.

I've also updated styled-system and system-components to their latest respective versions now that styled-system@3.1.3 fixed the missing space export. 😱

@vercel
Copy link

vercel bot commented Sep 14, 2018

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

@shawnbot

This comment has been minimized.

@shawnbot
Copy link
Contributor Author

Looks like the npm registry is flaking out on those last couple of Now deployments. Let's take another look at this on Monday. 🤞

@shawnbot
Copy link
Contributor Author

Well, using preval might not work here after all... this is super frustrating. I can't even reproduce the errors that are happening on Now locally. :rage4:

@shawnbot

This comment has been minimized.

@emplums
Copy link

emplums commented Sep 20, 2018

@shawnbot is this ready to re-review?

@shawnbot shawnbot changed the title Add BaseCSS component and static CSS build Add back Primer CSS build and instructions for using it Sep 20, 2018
@shawnbot
Copy link
Contributor Author

@emplums yep!

Copy link

@emplums emplums left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good!

@shawnbot shawnbot merged commit 315a501 into q3-lochness-monster Sep 20, 2018
@shawnbot shawnbot deleted the base-css branch September 20, 2018 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants