UnderlineNav2: Use useIsomorphicLayoutEffect to make it SSR friendly #2625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 08f09b9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
size-limit report 📦
|
joshblack
approved these changes
Dec 1, 2022
broccolinisoup
force-pushed
the
underlineNav-isomorphicLayoutEffect
branch
from
a390edc
to
2bd997d
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2617
This PR updates UnderlineNav using
useIsomorphicLayoutEffectinstead of React's defaultuseLayoutEffectto make it SSR friendly.Note: UnderlineNav's initial layout rendering is very much depending on viewport size and JS being ran on the browser to calculate how many items that can fit into the current viewport. Because of that, this update causes an undesirable behaviour in SSR. Nothing blocking the functionality though it is just something we have not worked thoroughly. I'll work with the design team to think about a "loading state" (Thanks @joshblack for this terminology!) until we get JS running on the browser.
In the meantime, it believe this should solve the issue.
Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.