make button as check strip out completely in production builds #2666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 961d92a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
6 tasks
size-limit report 📦
|
mattcosta7
temporarily deployed
to
github-pages
GitHub Actions
Inactive
joshblack
approved these changes
Dec 8, 2022
mattcosta7
changed the title
| React.useEffect(() => { | ||
| if (!(innerRef.current instanceof HTMLButtonElement) && !(innerRef.current instanceof HTMLAnchorElement)) { | ||
| if (__DEV__) { | ||
| if (__DEV__) { |
There was a problem hiding this comment.
thank you for the explanation!
kendallgassner
approved these changes
Dec 8, 2022
joshblack
temporarily deployed
to
github-pages
GitHub Actions
Inactive
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes here.
#2659 introduced a dev only check in an effect, but it doesn't completely strip that effect from production builds. This removes the entire effect from the production bundle by wrapping the whole effect in the compile flag check (which violates the eslint rule of hooks, but doesn't actually break the rules since this isn't conditional, but instead just included or excluded based on build properties - it will never change between render passes)
Screenshots
Please provide before/after screenshots for any visual changes
Merge checklist
No real behavior change should be apparent here