Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes z-index from "x" button in tokens #2689

Merged
merged 6 commits into from Dec 15, 2022

Conversation

mperrotti
Copy link
Contributor

Removes the z-index styling from the "x" button on tokens to resolve stacking context.

I tested the changes, and interactive tokens with "x" buttons still work as expected.

Closes #2626

Merge checklist

  • Added/updated tests
  • [n/a] Added/updated documentation
  • Tested in Chrome
  • Tested in Firefox
  • Tested in Safari
  • Tested in Edge

Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.

@mperrotti mperrotti requested review from a team and colebemis December 13, 2022 22:21
@changeset-bot
Copy link

changeset-bot bot commented Dec 13, 2022

🦋 Changeset detected

Latest commit: 1aca98b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Dec 13, 2022

size-limit report 📦

Path Size
dist/browser.esm.js 84.04 KB (-0.02% 🔽)
dist/browser.umd.js 84.66 KB (-0.02% 🔽)

@github-actions github-actions bot temporarily deployed to storybook-preview-2689 December 13, 2022 22:30 Inactive
@mperrotti mperrotti temporarily deployed to github-pages December 13, 2022 22:35 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-2689 December 13, 2022 22:36 Inactive
@mperrotti mperrotti temporarily deployed to github-pages December 15, 2022 18:59 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-2689 December 15, 2022 19:00 Inactive
@mperrotti mperrotti temporarily deployed to github-pages December 15, 2022 19:35 — with GitHub Actions Inactive
@mperrotti mperrotti merged commit 7fc9acd into main Dec 15, 2022
@mperrotti mperrotti deleted the mp/fix-token-rm-button-overlap branch December 15, 2022 20:06
@primer-css primer-css mentioned this pull request Dec 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Autocomplete.Overlay issue with TextInputWithTokens
2 participants