1518 react treeview feedback from screen reader #2710
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Josh Black <joshblack@users.noreply.github.com>
…eedback-from-screen-reader
🦋 Changeset detectedLatest commit: 84825f0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
size-limit report 📦
|
green6erry
temporarily deployed
to
github-pages
GitHub Actions
Inactive
green6erry
temporarily deployed
to
github-pages
GitHub Actions
Inactive
Could you expand on this? What do you think the root cause of this issue is? |
colebemis
reviewed
Dec 19, 2022
colebemis
reviewed
Dec 19, 2022
Co-authored-by: Cole Bemis <colebemis@github.com>
Co-authored-by: Cole Bemis <colebemis@github.com>
green6erry
temporarily deployed
to
github-pages
GitHub Actions
Inactive
…eedback-from-screen-reader
green6erry
temporarily deployed
to
github-pages
GitHub Actions
Inactive
green6erry
temporarily deployed
to
github-pages
GitHub Actions
Inactive
colebemis
reviewed
Jan 19, 2023
colebemis
reviewed
Jan 19, 2023
colebemis
approved these changes
Jan 19, 2023
There was a problem hiding this comment.
Thanks for walking me through these changes, @green6erry! Looks good to me. Just left a small suggestion about adding a code comment to explain isPending.
green6erry
temporarily deployed
to
github-pages
GitHub Actions
Inactive
green6erry
force-pushed
the
1518-react-treeview-feedback-from-screen-reader
branch
from
7f02e48
to
e22e310
Compare
green6erry
temporarily deployed
to
github-pages
GitHub Actions
Inactive
Co-authored-by: Cole Bemis <colebemis@github.com>
green6erry
temporarily deployed
to
github-pages
GitHub Actions
Inactive
green6erry
temporarily deployed
to
github-pages
GitHub Actions
Inactive
green6erry
temporarily deployed
to
github-pages
GitHub Actions
Inactive
green6erry
deleted the
1518-react-treeview-feedback-from-screen-reader
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes here.
Closes 1518 as somewhat of a bandaid for the issue. The reason this is happening is from a larger issue with the api. For now, the aria message is now updating the status correctly based on which branch is expanded.
Screenshots
Please provide before/after screenshots for any visual changes
Before:
Directory with async itemsis expanded, but the status reads that that the last child,Nested Directoryis empty. This is both not true, and irrelevant to expandingDirectory with async itemsAfter:
Now when
Directory with async itemsis expanded, the status accurately reads that it has loaded.Merge checklist
Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.