Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sx prop to Dialog v2 #2712

Merged
merged 4 commits into from
Dec 21, 2022
Merged

Conversation

ajhenry
Copy link
Contributor

@ajhenry ajhenry commented Dec 20, 2022

This changes the types of DialogProps to extend the SxProp and then passes it to the StyledDialog component so styles will apply correctly

Closes #2709

Merge checklist

  • Added/updated tests
  • Added/updated documentation
  • Tested in Chrome
  • Tested in Firefox
  • Tested in Safari
  • Tested in Edge

Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.

@ajhenry ajhenry requested review from a team and siddharthkp December 20, 2022 16:36
@changeset-bot
Copy link

changeset-bot bot commented Dec 20, 2022

🦋 Changeset detected

Latest commit: 54bdfd3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

@colebemis colebemis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thank you @ajhenry

@colebemis colebemis merged commit 88008a0 into primer:main Dec 21, 2022
@primer-css primer-css mentioned this pull request Dec 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dialog v2 is missing the sx prop
2 participants