Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jdrush89/fix linkitem onclick #2757

Merged
merged 7 commits into from
Jan 10, 2023

Conversation

jdrush89
Copy link
Contributor

@jdrush89 jdrush89 commented Jan 10, 2023

Call the onClick of ActionList.LinkItems when they are clicked. The onClick prop was allowed to be passed in, but was being overridden by ActionList.Item's clickHandler.

Closes #2724

Merge checklist

  • Added/updated tests
  • Added/updated documentation
  • Tested in Chrome
  • Tested in Firefox
  • Tested in Safari
  • Tested in Edge

Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.

@jdrush89 jdrush89 requested review from a team and josepmartins January 10, 2023 04:28
@changeset-bot
Copy link

changeset-bot bot commented Jan 10, 2023

🦋 Changeset detected

Latest commit: cae5835

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

@radglob radglob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work on this! Thanks!

Copy link
Member

@joshblack joshblack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this! 🥳

@joshblack joshblack enabled auto-merge (squash) January 10, 2023 18:19
@joshblack joshblack merged commit b55d823 into primer:main Jan 10, 2023
@primer-css primer-css mentioned this pull request Jan 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

onClick of ActionList.LinkItem not getting called
3 participants