feat(Button): add default type

[joshblack]

Closes #2806

Update the default type for Button to be "button". By default, buttons are inferred to be of type="submit" which can cause some unexpected behavior, especially within forms.

Changelog

New

Changed

• Add type="button" to Button.tsx

Removed

[changeset-bot]

🦋 Changeset detected

Latest commit: a5be8b0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@primer/react	Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[github-actions]

size-limit report 📦

Path	Size
dist/browser.esm.js	88.87 KB (+0.01% 🔺)
dist/browser.umd.js	89.48 KB (+0.01% 🔺)

[langermank]

Do you think this is a breaking change potentially?

[joshblack]

@langermank I think if someone relies on inferred type="submit" then unfortunately yeah, it could be considered one 😞

[iansan5653]

LGTM! Regarding moving this to ButtonBase instead: I don't think it's necessary because ButtonBase is only used elsewhere in LinkButton (which renders as an a tag) and some deprecated components.

This is theoretically a breaking change but I've personally never seen anyone rely on the implicit submit type of a button. I'd be surprised if this is done anywhere.

[joshblack]

I think we can try this out in the upcoming release and see how it lands, happy to revert it back if it becomes problematic!

[mattcosta7]

I go 50/50 on this, but agreed with feeling it out

I always think html is weird here by defaulting type to submit in forms, but also that consistency with html is nice (even though it's non-intuitive)