-
Notifications
You must be signed in to change notification settings - Fork 526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TreeView: Fix initial focus #2845
Conversation
🦋 Changeset detectedLatest commit: 645d0f5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
size-limit report 📦
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
// | ||
// WARNING: We don't recommend using TabNav inside an ActionMenu. | ||
// This is a workaround to avoid breaking existing code. | ||
focusInStrategy: isInsideMenu ? 'previous' : customStrategy, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updating focusInStrategy to be compatiable with TreeView caused some TabNav tests to fail so I needed to the TabNav focusZone behavior. cc @joshblack since you were the last person to touch this code in #2468
This also fixes #2855
Defines a custom
focusInStrategy
for thefocusZone
behavior so the "current" treeitem is focused by default when a user focuses a TreeView.Storybook preview
Closes https://github.com/github/primer/issues/1750
Before
CleanShot.2023-01-31.at.13.54.32.mp4
After
CleanShot.2023-01-31.at.13.52.14.mp4