TreeView: Refactor loading focus management #2868
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Josh Black <joshblack@users.noreply.github.com>
🦋 Changeset detectedLatest commit: 8b910d9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
size-limit report 📦
|
colebemis
temporarily deployed
to
github-pages
GitHub Actions
Inactive
colebemis
commented
Feb 6, 2023
colebemis
commented
Feb 6, 2023
colebemis
temporarily deployed
to
github-pages
GitHub Actions
Inactive
colebemis
temporarily deployed
to
github-pages
GitHub Actions
Inactive
colebemis
temporarily deployed
to
github-pages
GitHub Actions
Inactive
joshblack
approved these changes
Feb 13, 2023
colebemis
temporarily deployed
to
github-pages
GitHub Actions
Inactive
colebemis
temporarily deployed
to
github-pages
GitHub Actions
Inactive
colebemis
temporarily deployed
to
github-pages
GitHub Actions
Inactive
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Focus wasn't reliably moving from the loading item to asynchronously loaded items due to a
setTimeoutcall.Solution
@joshblack and I figured out how to implement the focus behavior without a
setTimeoutcall.Before
Notice that focus disappears after items are loaded:
CleanShot.2023-02-08.at.23.21.14.mp4
After
CleanShot.2023-02-08.at.23.20.10.mp4
Co-authored-by: Josh Black joshblack@users.noreply.github.com