Support custom emojis & declarative loading state in MarkdownEditor suggestions
#3004
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 19f6833 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
size-limit report 📦
|
…hub.com/primer/react into markdown-editor-suggestion-improvements
iansan5653
changed the title
loading state in MarkdownEditor suggestions
mperrotti
approved these changes
Mar 9, 2023
| {name: '+1', character: '👍'}, | ||
| {name: '-1', character: '👎'}, | ||
| {name: 'heart', character: '❤️'}, | ||
| {name: 'wave', character: '👋'}, | ||
| {name: 'raised_hands', character: '🙌'}, | ||
| ] | ||
| {name: 'octocat', url: 'https://github.githubassets.com/images/icons/emoji/octocat.png'}, | ||
| ] satisfies Emoji[] |
There was a problem hiding this comment.
Ohh I've read about satisfies but haven't actually used it yet. Nice.
There was a problem hiding this comment.
turns out I had to remove it because the Jest transpiler doesn't work with it
joshblack
approved these changes
Mar 9, 2023
|
@iansan5653 sorry about the Jest issue! just opened up: #3005 to avoid this in the future for TypeScript 4.9 features like |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
{name: string, url: string}whereurlis an image."loading"as the suggestions prop. We already supported asynchronous suggestions via an async function, but this imperative strategy isn't idiomatic React and is incompatible withreact-query, which we'd like to use in Projects for caching data more effectively. My bad for originally writing it this way 😬. I'd really like to completely change it but I want to avoid breaking changes for now and this works just fine.This change is completely non-breaking and won't require any additional QA if we can get it into this release (as evidenced by the Storybook stories which didn't require any changes).