Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More a11y improvements for Pagination #3029

Merged
merged 6 commits into from
Mar 15, 2023
Merged

Conversation

mperrotti
Copy link
Contributor

  • Instead of making the current page an <em> tag, keep it as a clickable link
  • Change the tone the screenreader uses when reading the last number before we start skipping numbers. This was done by appending "..." to the aria-labels of those pages.

Screenshots

There should be no visual changes

Merge checklist

  • Added/updated tests
  • Added/updated documentation
  • Tested in Chrome
  • Tested in Firefox
  • Tested in Safari
  • Tested in Edge

Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.

@mperrotti mperrotti requested review from a team and JoshBowdenConcepts March 14, 2023 21:05
@changeset-bot
Copy link

changeset-bot bot commented Mar 14, 2023

🦋 Changeset detected

Latest commit: 909aacb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Mar 14, 2023

size-limit report 📦

Path Size
dist/browser.esm.js 94.52 KB (+0.05% 🔺)
dist/browser.umd.js 95.1 KB (+0.06% 🔺)

@github-actions github-actions bot temporarily deployed to storybook-preview-3029 March 14, 2023 21:12 Inactive
@mperrotti mperrotti temporarily deployed to github-pages March 14, 2023 21:12 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-3029 March 14, 2023 21:13 Inactive
Copy link
Member

@joshblack joshblack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Definitely noticed the difference in pitch with NVDA 👍

src/Pagination/model.tsx Outdated Show resolved Hide resolved
@github-actions github-actions bot temporarily deployed to storybook-preview-3029 March 15, 2023 20:44 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-3029 March 15, 2023 20:45 Inactive
@mperrotti mperrotti added this pull request to the merge queue Mar 15, 2023
Merged via the queue into main with commit bb9f156 Mar 15, 2023
@mperrotti mperrotti deleted the mp/pagination-a11y-improvements branch March 15, 2023 21:02
@primer-css primer-css mentioned this pull request Mar 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants