Use open/closed colors for StateLabel

[simurai]

This is a follow-up to https://github.com/github/primer/issues/725 and replaces the success/danger colors with open/closed colors for StateLabel. See ADR for reasoning. Note that only color blind themes are affected.

Closes #3038

Screenshots

Please provide before/after screenshots for any visual changes

Before	After

This should match PVC's State component for the color blind themes:

Merge checklist

• Added/updated tests
• Added/updated documentation
• Tested in Chrome
• Tested in Firefox
• Tested in Safari
• Tested in Edge

Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.

[changeset-bot]

🦋 Changeset detected

Latest commit: 968ce29

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@primer/react	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[github-actions]

size-limit report 📦

Path	Size
dist/browser.esm.js	94.6 KB (-0.01% 🔽)
dist/browser.umd.js	95.22 KB (0%)

[simurai]

@joshblack I added the update snapshots label and it updated the snapshots with 8865a6a but the vrt/aat checks are still failing. Is there another step to tell that the new snapshots are the new and correct ones?

[joshblack]

Hey @simurai! Thanks for bringing this up, fixed a bug with how the snapshots were being uploaded to make sure the missing ones were brought in 👀

For the a11y violations, are those contrast violations expected? If so, happy to batch them up with the other tests where we are ignoring them but just wanted to double-check with you first 👍

[simurai]

@joshblack For the a11y violations, are those contrast violations expected? If so, happy to batch them up with the other tests where we are ignoring them but just wanted to double-check with you first 👍

Ahh.. yes. I can see the contrast failing in Storybook too.

There are potential solutions, but that's something that would need to be fixed in Primitives.

Is there a way to add an exception for now?

[joshblack]

@simurai definitely! Just pushed something up for it. For any tests that we want to ignore color contrast, we can omit the options passed to toHaveNoViolations() and contrast by default should not be included as a check 👍

[simurai]

Just pushed something up for it.

Thanks. 🙇 All checks pass now. 👍

[simurai]

@joshblack Just pushed something up for it.

All checks pass now. 👍 Thanks. 🙇