You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because this is a major change, the PR should have been created and merged against the next-major branch which then would end up in the v36 major release tracking PR. I am reverting this commit in the main so we have a clean minor release tracking PR.
After we merge this PR into main, we should do;
Cherry pick 87883c3fd91a5d2809268aa0dd22b87b53ba5309 and resolve conflicts
Push up a new PR and make sure mark the target branch as next-major
After that, I think we can merge the PR as it has already been approved.
Also, If there is any other way to solve this, please let me know or feel free to do so. This was the only one I came up with!
Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
broccolinisoup
changed the title
Revert "Update PRC ActionList implementation to have similar semantic…
Revert "Update PRC ActionList implementation to have similar semantics to PVC. (#2878)"
May 3, 2023
The reason will be displayed to describe this comment to others. Learn more.
Definitely makes sense with the major change in there, seems like we should have a way to either ship it in a stable behind a flag or namespace or include it with the next major release. Is there a clear preference in either case? Would this be something helpful to go over in our weekly sync or async in Slack? 👀
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
broccolinisoup
changed the title
This reverts commit 87883c3 (PR)
Because this is a major change, the PR should have been created and merged against the
next-majorbranch which then would end up in the v36 major release tracking PR. I am reverting this commit in the main so we have a clean minor release tracking PR.After we merge this PR into main, we should do;
87883c3fd91a5d2809268aa0dd22b87b53ba5309and resolve conflictsnext-majorAfter that, I think we can merge the PR as it has already been approved.
Also, If there is any other way to solve this, please let me know or feel free to do so. This was the only one I came up with!
Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.