Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Q4 Haunted Kittens Release Tracking PR 👻 #327

Merged
merged 53 commits into from Oct 26, 2018
Merged

Q4 Haunted Kittens Release Tracking PR 👻 #327

merged 53 commits into from Oct 26, 2018

Conversation

emplums
Copy link

@emplums emplums commented Oct 23, 2018 •
edited

🚀 New features

🚨 Breaking Changes

  • Removed the src and alt props from CircleBadge. Use an img as a child of CircleBadge, and add alt text there instead. CircleBadge cleanup #332
  • Button updates: Button & Link Updates #330
    • added width prop
    • Removed block prop
  • Removed ButtonLink component - users should use a <Link is='button'> for this use case. The model here should be Button is a UI element that is styled like a button. Link is a UI element that is styled like a link. You can change the tag as needed. Button & Link Updates #330
  • Removed border, borderRadius, BorderColor and BoxShadow props from Box, added them to BorderBox BorderBox updates #329

🐛 Bug Fixes

  • Fixed Actions bugs

Version to be Published: 5.0.0-beta

Merge checklist

  • Correct version number?
  • Tested in Chrome
  • Tested in Firefox
  • Tested in Safari
  • Tested in Edge

@vercel
Copy link

vercel bot commented Oct 23, 2018

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

Emily and others added 24 commits October 23, 2018 15:24
update tests
2f2c67e
Merge branch 'update-theme' of github.com:primer/components into upda…
fee56d7 
…te-theme
fix lint
f84c9e5
Merge pull request #326 from primer/update-theme
5e6631b 
Add fontWeights to theme
@shawnbot
rename Octicon -> StyledOcticon
ae2472a
@shawnbot
export StyledOcticon
ff92ad4
@shawnbot
sort exports alphabetically
5104eef
@shawnbot
add basic StyledOcticon tests
ea04179
@shawnbot
lint
4917616
@shawnbot
Merge remote-tracking branch 'origin/q4-haunted-kittens' into styled-…
1ffbec9 
…octicon
@shawnbot
fix the StyledOcticon snapshot 😬
6818e7b
@shawnbot
add StyledOcticon docs
2bb146c
@shawnbot
Merge pull request #328 from primer/styled-octicon
9a92011 
Octicon → StyledOcticon, export, tests
remove border props from Layout, add to BorderBox
43d59f5
update Box tests
f21d4e8
Fix CircleOcticon
2f09185
update Dropdown
d89c08f
set bg on CircleOcticon
9141a68
remove unnecessary imports
e31d077
update snaps
d7c5c7b
lint
33be761
pass boxShadow as string
92c6ed6
add some tests
2b5eded
lint
83cd4f7
Emily and others added 24 commits October 25, 2018 10:01
Merge branch 'q4-haunted-kittens' into border-box
f5995fb
add width and remove block
3cc354e
remove ButtonLink
d2bef28
remove linkStyle
8f59e16
add ability to change tag to Link
2c9adca
add props validation
abba828
styles should live in component instead of using classname
2feb606
@shawnbot
update example
1e9e654 
Co-Authored-By: emplums <emplums@github.com>
update link prop types
e4ebef0
Merge branch 'button-updates' of github.com:primer/components into bu…
7bdd44d 
…tton-updates
clean up Link component
0600b45
update Button tests
761b454
update Dropdown snapshot
fa63c7d
Link snapshot
6b48afc
Merge branch 'q4-haunted-kittens' into button-updates
a604f32
remove semibold from theme
bc5b1b6
remove alt and src props
d0d3e87
lint
b4d1180
Merge pull request #329 from primer/border-box
566a369 
BorderBox updates
Merge pull request #331 from primer/remove-semibold
251760e 
remove semibold from theme
Merge pull request #332 from primer/circlebadge
467c8d9 
CircleBadge cleanup
fix lint
62acd3e
Merge pull request #330 from primer/button-updates
d417697 
Button & Link Updates
remove clean-tag
1fcd6e1
shawnbot
shawnbot approved these changes Oct 26, 2018
View reviewed changes
Copy link
Contributor

@shawnbot shawnbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@emplums emplums merged commit d793061 into master Oct 26, 2018
@emplums emplums deleted the q4-haunted-kittens branch October 26, 2018 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shawnbot shawnbot shawnbot approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@emplums @shawnbot