Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Pagination component snapshot #3292

Merged
merged 1 commit into from
May 17, 2023
Merged

Update Pagination component snapshot #3292

merged 1 commit into from
May 17, 2023

Conversation

adrianababakanian
Copy link
Contributor

Describe your changes here.

Updates the snapshots for the Pagination component that started failing with the changes in #3277

Screenshots

N/A

Merge checklist

  • Added/updated tests
  • Added/updated documentation
  • Tested in Chrome
  • Tested in Firefox
  • Tested in Safari
  • Tested in Edge

Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.

@adrianababakanian adrianababakanian requested review from a team and mperrotti May 16, 2023 21:57
@changeset-bot
Copy link

changeset-bot bot commented May 16, 2023

⚠️ No Changeset found

Latest commit: 66d4287

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@broccolinisoup broccolinisoup added the skip changeset This change does not need a changelog label May 17, 2023
colebemis
colebemis approved these changes May 17, 2023
View reviewed changes
Copy link
Contributor

@colebemis colebemis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix, @adrianababakanian!

@colebemis colebemis merged commit dfbf551 into primer:main May 17, 2023
@broccolinisoup broccolinisoup mentioned this pull request May 17, 2023
Merged
6 tasks
adrianababakanian added a commit that referenced this pull request Jun 21, 2023
@adrianababakanian
Update Pagination component snapshot (#3292)
24778f8
adrianababakanian added a commit that referenced this pull request Jun 22, 2023
@adrianababakanian
Revert "Update Pagination component snapshot (#3292)"
4e05c8e 
This reverts commit 24778f8.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colebemis colebemis colebemis approved these changes

@mperrotti mperrotti Awaiting requested review from mperrotti

Assignees
No one assigned
Labels
skip changeset This change does not need a changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@adrianababakanian @colebemis @broccolinisoup