Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SelectPanel: Add subtitle prop #3322

Merged
merged 7 commits into from
Jun 7, 2023
Merged

SelectPanel: Add subtitle prop #3322

merged 7 commits into from
Jun 7, 2023

Conversation

colebemis
Copy link
Contributor

@colebemis colebemis commented May 24, 2023

Adds an optional subtitle prop to SelectPanel:

Part of https://github.com/github/primer/issues/2087

Screenshots

CleanShot 2023-05-24 at 12 47 40@2x

Merge checklist

  • Added/updated tests
  • Added/updated documentation
  • Changes are SSR compatible
  • Tested in Chrome
  • Tested in Firefox
  • Tested in Safari
  • Tested in Edge

Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.

@changeset-bot
Copy link

changeset-bot bot commented May 24, 2023

🦋 Changeset detected

Latest commit: f01e39a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented May 24, 2023

size-limit report 📦

Path Size
dist/browser.esm.js 101.86 KB (+0.04% 🔺)
dist/browser.umd.js 102.35 KB (+0.05% 🔺)

@github-actions github-actions bot temporarily deployed to storybook-preview-3322 May 24, 2023 19:04 Inactive
@primer primer bot temporarily deployed to github-pages May 24, 2023 19:05 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-3322 May 24, 2023 19:05 Inactive
@colebemis colebemis marked this pull request as ready for review May 24, 2023 19:53
@colebemis colebemis requested review from a team and joshblack May 24, 2023 19:53
@colebemis colebemis temporarily deployed to github-pages May 24, 2023 19:59 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-3322 May 24, 2023 19:59 Inactive
@colebemis colebemis temporarily deployed to github-pages May 24, 2023 20:23 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-3322 May 24, 2023 20:23 Inactive
@colebemis colebemis added this pull request to the merge queue Jun 7, 2023
Merged via the queue into main with commit c0b2fcf Jun 7, 2023
28 checks passed
@colebemis colebemis deleted the selectpanel-subtitle-prop branch June 7, 2023 19:05
This was referenced Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants