Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UnderlineNav2: Remove selectionVariant prop from stories and refactor accordingly #3393

Closed
wants to merge 1 commit into from

Conversation

broccolinisoup
Copy link
Member

Reverting some changes back on UnderlineNav that was introduced #2878

We need to pass selectionVariant="single" on the ActionList in UnderlineNav because we call onSelect function. If we don't set it, it throws an error when an item is selected (ActionList ref)

To be able to hide the CheckIcon we can use styling. This is how it was originally done but I took this as an opportunity and update the styling to check a data component rather than relying on the node order in the dom.

Screenshots

No visual changes

Merge checklist

  • Added/updated tests
  • Added/updated documentation
  • Changes are SSR compatible
  • Tested in Chrome
  • Tested in Firefox
  • Tested in Safari
  • Tested in Edge

Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.

@broccolinisoup broccolinisoup added the skip changeset This change does not need a changelog label Jun 9, 2023
@broccolinisoup broccolinisoup requested review from a team and mperrotti June 9, 2023 08:20
@changeset-bot
Copy link

changeset-bot bot commented Jun 9, 2023

⚠️ No Changeset found

Latest commit: 8cf6a54

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@broccolinisoup broccolinisoup changed the title UnderlineNav: Remove selectionVariant prop from stories and refactor accordingly UnderlineNav2: Remove selectionVariant prop from stories and refactor accordingly Jun 9, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jun 9, 2023

size-limit report 📦

Path Size
dist/browser.esm.js 101.88 KB (+0.01% 🔺)
dist/browser.umd.js 102.4 KB (+0.04% 🔺)

@broccolinisoup
Copy link
Member Author

Because the PR that introduced the problem that we are addressing here, is reverted I am closing this PR, and it is already been fixed in the new draft PR that re-introduces the changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip changeset This change does not need a changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants