UnderlineNav2: Remove selectionVariant
prop from stories and refactor accordingly
#3393
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverting some changes back on
UnderlineNav
that was introduced #2878We need to pass
selectionVariant="single"
on the ActionList in UnderlineNav because we callonSelect
function. If we don't set it, it throws an error when an item is selected (ActionList ref)To be able to hide the
CheckIcon
we can use styling. This is how it was originally done but I took this as an opportunity and update the styling to check a data component rather than relying on the node order in the dom.Screenshots
No visual changes
Merge checklist
Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.