Q4 Cool Zoo Release PR #349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically deployed with Now. |
Update system prop categories in docs
shawnbot
reviewed
Nov 7, 2018
| | `TYPOGRAPHY`| fontFamily, fontSize, fontWeight, lineHeight & all `COMMON` props | [styled-system typography docs](https://github.com/jxnblk/styled-system/blob/master/docs/table.md#typography) | | ||
| | `LAYOUT` | borders, borderColor, borderRadius, boxShadow, <br/> display, size, width, height, minWidth, minHeight, <br/> maxWidth, maxHeight, verticalAlign & all `COMMON` props | [styled-system layout docs](https://github.com/jxnblk/styled-system/blob/master/docs/table.md#layout) <br/> [styled-system misc docs](https://github.com/jxnblk/styled-system/blob/master/docs/table.md#misc) | | ||
| | `POSITION` | position, zIndex, top, right, bottom, left | [styled-system position docs](https://github.com/jxnblk/styled-system/blob/master/docs/table.md#position) | ||
| | `COMMON`| <Text children={printProps(COMMON)} /> | [styled-system core docs](https://github.com/jxnblk/styled-system/blob/master/docs/table.md#core) | |
There was a problem hiding this comment.
Looking at this now, I wonder if having a component to render the props list would be DRY-er?
<PropsList>{COMMON}</PropsList>
// replacing printProps():
export const PropsList = ({children}) => children.join(', ')
PropsList.propTypes = {children: PropTypes.arrayOf(PropTypes.string)}
There was a problem hiding this comment.
I'll add this as an issue to do in a follow up PR!
There was a problem hiding this comment.
JK i just went ahead and did it in this branch 😉
Co-Authored-By: emplums <emplums@github.com>
Redirect from / to /components
Fix duplicated SSR styles
Co-Authored-By: emplums <emplums@github.com>
README updates
Update Octicons
RFC extend Box in BorderBox, remove default bg
jonrohan
approved these changes
Nov 16, 2018
added 2 commits
November 16, 2018 12:08
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💅 Enhancements
flexfrom FLEX_CONTAINER props and put it in FLEX_ITEM Update system prop categories in docs #347COMMONinto other categories insystem-props.jsand instead do it within each component to make this more explicit Update system prop categories in docs #347📝 Documentation
primer.style/componentsand the non-aliased deployment URL) now redirects from/to/componentsRedirect from / to /components #355Version to be Published: 7.0.0-beta
Merge checklist