Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PageLayout docs #3684

Merged
merged 3 commits into from
Aug 29, 2023
Merged

Conversation

TylerJDev
Copy link
Contributor

Updates PageLayout docs to reflect the new changes to PageLayout.Content component.

This was shipped previously but was reverted with other PRs.

Screenshots

Please provide before/after screenshots for any visual changes

Merge checklist

  • Added/updated tests
  • Added/updated documentation
  • Changes are SSR compatible
  • Tested in Chrome
  • Tested in Firefox
  • Tested in Safari
  • Tested in Edge

Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 29, 2023

size-limit report 📦

Path Size
dist/browser.esm.js 104.58 KB (0%)
dist/browser.umd.js 105.13 KB (0%)

@TylerJDev TylerJDev added the skip changeset This change does not need a changelog label Aug 29, 2023
@TylerJDev TylerJDev temporarily deployed to github-pages August 29, 2023 17:25 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-3684 August 29, 2023 17:25 Inactive
@changeset-bot
Copy link

changeset-bot bot commented Aug 29, 2023

⚠️ No Changeset found

Latest commit: b575a19

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Member

@joshblack joshblack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

Just wanted to double check, does this mean aria-label and aria-labelledby should be deprecated on PageLayout.Content? (and removed in a future major version)

@TylerJDev
Copy link
Contributor Author

Looks great!

Just wanted to double check, does this mean aria-label and aria-labelledby should be deprecated on PageLayout.Content? (and removed in a future major version)

Definitely, right now these attributes are being applied to a generic <div>, so we'll want to deprecate them entirely from PageLayout.Content when we can.

@TylerJDev TylerJDev added this pull request to the merge queue Aug 29, 2023
Merged via the queue into main with commit 6bc72c1 Aug 29, 2023
31 checks passed
@TylerJDev TylerJDev deleted the tylerjdev/update-pagelayout-docs-main-once-more branch August 29, 2023 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip changeset This change does not need a changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants