-
Notifications
You must be signed in to change notification settings - Fork 528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update PageLayout docs #3684
Update PageLayout docs #3684
Conversation
size-limit report 📦
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
Just wanted to double check, does this mean aria-label
and aria-labelledby
should be deprecated on PageLayout.Content
? (and removed in a future major version)
Definitely, right now these attributes are being applied to a generic |
Updates PageLayout docs to reflect the new changes to
PageLayout.Content
component.This was shipped previously but was reverted with other PRs.
Screenshots
Please provide before/after screenshots for any visual changes
Merge checklist
Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.