Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Tooltip border-radius from 3px to 6px #4204

Merged
merged 6 commits into from
Feb 6, 2024
Merged

Conversation

dylanatsmith
Copy link
Contributor

The Tooltip border-radius is inconsistent between Rails and React components. This is obvious where the two live side-by-side, like the global Copilot header button.

This PR assumes Rails is correct and changes React to match.

Screen.Recording.2024-02-01.at.11.59.58.mov
Screen.Recording.2024-02-01.at.12.00.24.mov

Changelog

New

Changed

Tooltip border-radius

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

@dylanatsmith dylanatsmith self-assigned this Feb 1, 2024
@dylanatsmith dylanatsmith requested review from a team and langermank February 1, 2024 12:00
Copy link

changeset-bot bot commented Feb 1, 2024

🦋 Changeset detected

Latest commit: a4edb42

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Feb 1, 2024

size-limit report 📦

Path Size
dist/browser.esm.js 113.22 KB (0%)
dist/browser.umd.js 113.86 KB (0%)

Copy link
Member

@joshblack joshblack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Will defer to @langermank for a visual review 👀

Copy link
Contributor

@langermank langermank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heads up we're about to refactor this design (CC @broccolinisoup) but probably no harm in merging this?

@broccolinisoup
Copy link
Member

Heads up we're about to refactor this design (CC @broccolinisoup) but probably no harm in merging this?

Thanks for the heads up @langermank !! No problem at all, I'll just take that line back in this PR

@dylanatsmith
Copy link
Contributor Author

@langermank @broccolinisoup Can either of you help me with the failing test on this? I’m not sure where/how to update it.

@langermank
Copy link
Contributor

@dylanatsmith try running npm test -- -u and push the snapshot changes up

Merged via the queue into main with commit da4469d Feb 6, 2024
30 checks passed
@dylanatsmith dylanatsmith deleted the dylanatsmith-patch-1 branch February 6, 2024 20:31
@primer primer bot mentioned this pull request Feb 6, 2024
@dylanatsmith
Copy link
Contributor Author

Thanks @joshblack @langermank 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants