Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SelectPanel2: Cancel + close panel when user clicks outside #4294

Merged
merged 6 commits into from
Feb 22, 2024
Merged

SelectPanel2: Cancel + close panel when user clicks outside #4294

merged 6 commits into from
Feb 22, 2024

Conversation

siddharthkp
Copy link
Member

@siddharthkp siddharthkp commented Feb 21, 2024 •
edited

  1. selectionVariant=instant
  • Clicking on option selects it, calls onSubmit and closes the menu
  • Clicking cancel button or close button calls onCancel and closes the menu
  • Clicking outside calls onCancel and closes the menu
  1. selectionVariant=multiple | single
  • Clicking on option selects it.
  • Clicking save calls onSubmit and closes the menu
  • Clicking cancel button or close button calls onCancel and closes the menu
  • Clicking outside calls onCancel and closes the menu

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Feb 21, 2024 •
edited

🦋 Changeset detected

Latest commit: 517a84f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@siddharthkp siddharthkp self-assigned this Feb 21, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 21, 2024 •
edited

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 113.47 KB (0%)
packages/react/dist/browser.umd.js 114.14 KB (0%)

@github-actions github-actions bot temporarily deployed to storybook-preview-4294 February 21, 2024 15:01 Inactive
@siddharthkp siddharthkp marked this pull request as ready for review February 21, 2024 15:08
@siddharthkp siddharthkp requested a review from a team February 21, 2024 15:08
@github-actions github-actions bot temporarily deployed to storybook-preview-4294 February 22, 2024 15:45 Inactive
@siddharthkp siddharthkp added this pull request to the merge queue Feb 22, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 22, 2024
@siddharthkp siddharthkp added this pull request to the merge queue Feb 22, 2024
Merged via the queue into main with commit 5ca5c0a Feb 22, 2024
30 checks passed
@siddharthkp siddharthkp deleted the drafts-selectpanel-click-outside branch February 22, 2024 16:40
@primer primer bot mentioned this pull request Feb 20, 2024
Merged
@siddharthkp siddharthkp changed the title experimental/SelectPanel: Cancel + close panel when user clicks outside SelectPanel2: Cancel + close panel when user clicks outside Mar 19, 2024
lukasoppermann pushed a commit that referenced this pull request Apr 16, 2024
@siddharthkp @lukasoppermann
experimental/SelectPanel: Cancel + close panel when user clicks outsi…
486c296 
…de (#4294)

* close on clicking outside

* add link to decision log

* Create nervous-dogs-change.md

* add onCancel to all examples

* oopsie!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshblack joshblack joshblack approved these changes

Assignees

@siddharthkp siddharthkp

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@siddharthkp @joshblack