Unify Breadcrumbs + fix a11y issues #4308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 281ca10 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
size-limit report 📦
|
…primer/react into tbenning/unify-breadcrumbs-a11y
tbenning
changed the title
…primer/react into tbenning/unify-breadcrumbs-a11y
langermank
approved these changes
Feb 29, 2024
Merged
lukasoppermann
pushed a commit
that referenced
this pull request
Apr 16, 2024
* update to fix a11y breadcrumb issue * Create fair-countries-taste.md * test(vrt): update snapshots * show underline on focus to resolve a11y issue * update tests --------- Co-authored-by: tbenning <tbenning@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update breadcrumb divider so that the screenreader doesn't read out the
/fromcontent:"/".Before
before.mov
After
after.mov
Closes #
https://github.com/github/primer/issues/3069
Closes a11y issue:
https://github.com/github/primer/issues/3074
Also closes a11y issue:
https://github.com/github/accessibility-audits/issues/5656
Rollout strategy
Testing & Reviewing
Merge checklist