Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SelectPanel2: Move focus to first item if there is no filter input #4320

Merged
merged 3 commits into from
Mar 7, 2024

Conversation

siddharthkp
Copy link
Member

@siddharthkp siddharthkp commented Feb 28, 2024

Before After
initial focus is on the first interactive element, the close button initial focus is on the first list element
initial focus is on the first interactive element, the close button initial focus is on the first list element

Copy link

changeset-bot bot commented Feb 28, 2024

🦋 Changeset detected

Latest commit: 66b5d3a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@siddharthkp siddharthkp self-assigned this Feb 28, 2024
@siddharthkp siddharthkp marked this pull request as ready for review February 28, 2024 15:16
@siddharthkp siddharthkp requested a review from a team February 28, 2024 15:16
Copy link
Contributor

github-actions bot commented Feb 28, 2024

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 113.71 KB (0%)
packages/react/dist/browser.umd.js 114.38 KB (0%)

@siddharthkp siddharthkp requested a review from a team as a code owner March 7, 2024 11:23
@siddharthkp siddharthkp added this pull request to the merge queue Mar 7, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 7, 2024
@siddharthkp siddharthkp added this pull request to the merge queue Mar 7, 2024
Merged via the queue into main with commit 7cb3464 Mar 7, 2024
30 checks passed
@siddharthkp siddharthkp deleted the draft-selectpanel-minimal-initial-focus branch March 7, 2024 11:54
@primer primer bot mentioned this pull request Mar 7, 2024
@siddharthkp siddharthkp changed the title experimental/SelectPanel: Move focus to first item if there is no filter input SelectPanel2: Move focus to first item if there is no filter input Mar 19, 2024
lukasoppermann pushed a commit that referenced this pull request Apr 16, 2024
…ter input (#4320)

* move focus to list if there is no input

* Create neat-toes-build.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants