-
Notifications
You must be signed in to change notification settings - Fork 506
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SelectPanel2: Move focus to first item if there is no filter input #4320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
siddharthkp
commented
Feb 28, 2024
•
edited
edited
Before | After |
---|---|
initial focus is on the first interactive element, the close button | initial focus is on the first list element |
🦋 Changeset detectedLatest commit: 66b5d3a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
size-limit report 📦
|
joshblack
approved these changes
Feb 28, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Mar 7, 2024
Merged
siddharthkp
changed the title
experimental/SelectPanel: Move focus to first item if there is no filter input
SelectPanel2: Move focus to first item if there is no filter input
Mar 19, 2024
lukasoppermann
pushed a commit
that referenced
this pull request
Apr 16, 2024
…ter input (#4320) * move focus to list if there is no input * Create neat-toes-build.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.