Add precompile step for colorSchemes #4337
Conversation
🦋 Changeset detectedLatest commit: 5ff242b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
size-limit report 📦
|
|
This looks promising! Let's test it with gh/gh for any accidental errors |
Bundle diffbefore: Stat: 309kb
after: Stat: 325kb (+16kb)
The raw bundle is slightly bigger, but smaller when Parsed or Gzipped |
There was a problem hiding this comment.
Thanks for taking the time to do this! Really appreciate you exploring this to improve performance in this area.
One question I had was if it was possible to statically update src/legacy-theme/ts/colors/index.ts into the intended format that the precompile step is taking or if this is something that will always need to execute, whether that's on load or at a precompile step.
|
hey @joshblack technically we don't need the compile step, we could just copy the output and put it in a static file. If those colors rarely change I think that could be a good idea. I made it a compile step simply because I don't know how often they change and I thought it could be easier for a developer to edit the base files and then the compile step taking care of converting everything into a big object |
* Add precompile step for colorSchemes * ignore generated file in prettier * Create tasty-spoons-suffer.md
Closes #
#4336
Changelog
Precompile colorSchemes to make load times faster.
New
precompile-color-schemesbuild step that will output a.tsfile with the precompiled object.Removed
Rollout strategy
Testing & Reviewing
Merge checklist