-
Notifications
You must be signed in to change notification settings - Fork 507
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add optional footer
prop to SelectPanel
#4353
Conversation
🦋 Changeset detectedLatest commit: c495eaa The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
size-limit report 📦
|
Since this is the old |
Uh oh! @pksjce, the image you shared is missing helpful alt text. Check #4353 (comment). Alt text is an invisible description that helps screen readers describe images to blind or low-vision users. If you are using markdown to display images, add your alt text inside the brackets of the markdown image. Learn more about alt text at Basic writing and formatting syntax: images on GitHub Docs. |
thanks both @siddharthkp and @pksjce ! I update the examples to better reflect the use-case, let's also do a follow up for the focus state later. |
Tiny update: Moved space inside the footer instead of story + Updated changelog |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good now!
* Spike on adding a footer * Update changelog * Storybook update * Update styling * move margin to internal padding space * Update bright-foxes-hunt.md * Update bright-foxes-hunt.md --------- Co-authored-by: Pavithra Kodmad <pksjce@github.com> Co-authored-by: Siddharth Kshetrapal <siddharthkp@github.com>
Issue - https://github.com/github/issues/issues/8775
This PR now adds an optional
footer
that will be rendered, sticky, at the bottom of theSelectPanel
if provided. This could be useful for adding in additional options to be present.Changelog
New
New prop,
footer
, toSelectPanel
.Changed
N/A.
Removed
N/A.
Rollout strategy
Testing & Reviewing
Testing via the storybook should be sufficient.
Merge checklist