Update README.md #4393
Merged
Update README.md #4393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We want to make our template more discoverable. - [馃挰 Internal Slack thread](https://github.slack.com/archives/C02NUUQ9C30/p1710415630143979)
馃 Changeset detectedLatest commit: 2dc9dcb The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
size-limit report 馃摝
|
| @@ -0,0 +1,5 @@ | |||
| --- | |||
| "@primer/react": patch | |||
There was a problem hiding this comment.
We usually release the docs changes without a changeset but did you want to announce this in the release notes?
There was a problem hiding this comment.
That was my plan. I was getting a warning though because there wasn't a changeset?
There was a problem hiding this comment.
Yeah the CI job will fail if there is no changeset. You could either add a changeset like you did here or you can add skip changeset label.
owenniblock
approved these changes
Mar 15, 2024
Co-authored-by: Owen Niblock <owenniblock@github.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We wanted to make our template more discoverable to avoid that internal employees have to set up their own project and run into unexpected issues.