Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update octicons-react and add range for primitives #4417

Merged
merged 5 commits into from
Mar 20, 2024

Conversation

joshblack
Copy link
Member

Update @primer/octicons-react to the latest version. This PR also adds a range to both @primer/octicons-react and @primer/primitives to improve support downstream with monorepos. On our end, in package.json files we should specify the minimum version required for the package so that downstream users can more easily dedupe package versions.

Changelog

New

Changed

  • Update @primer/octicons-react to 19.9.0
  • Add ^ range operator to @primer dependencies

Removed

Rollout strategy

  • Minor release

Testing & Reviewing

  • Verify that icon changes don't introduce a regression in some way
  • Verify that snapshots don't change meaningfully

@joshblack joshblack requested a review from a team as a code owner March 19, 2024 20:00
Copy link

changeset-bot bot commented Mar 19, 2024

🦋 Changeset detected

Latest commit: ed68403

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

@langermank langermank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay thank you! This bit me today in dotcom 😅

Copy link
Contributor

github-actions bot commented Mar 19, 2024

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 87.56 KB (+0.03% 🔺)
packages/react/dist/browser.umd.js 87.94 KB (+0.15% 🔺)

Copy link
Collaborator

@camertron camertron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you ❤️

@github-actions github-actions bot temporarily deployed to storybook-preview-4417 March 20, 2024 16:56 Inactive
@joshblack joshblack added this pull request to the merge queue Mar 20, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 20, 2024
@joshblack joshblack added this pull request to the merge queue Mar 20, 2024
Merged via the queue into main with commit d7f4f7c Mar 20, 2024
30 checks passed
@joshblack joshblack deleted the feat/update-primer-deps branch March 20, 2024 17:56
@primer primer bot mentioned this pull request Mar 20, 2024
lukasoppermann pushed a commit that referenced this pull request Apr 16, 2024
* chore(deps): update octicons-react and add range for primitives

* chore: add changeset

* chore(project): update lockfile

* chore(test): update snapshots

* chore: try to increase timeout limits for ci

---------

Co-authored-by: Josh Black <joshblack@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants