-
Notifications
You must be signed in to change notification settings - Fork 507
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use getGlobalFocusStyles
in ToggleSwitch
#4451
Conversation
🦋 Changeset detectedLatest commit: 6f5bd70 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
size-limit report 📦
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! 🎉
.changeset/light-zebras-mix.md
Outdated
'@primer/react': patch | ||
--- | ||
|
||
Utilize `getGlobalFocusStyle` to prevent `outline-offset` from being overridden by global styles |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nitpick and totally optional:
- global styles
+ default browser styles
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This works for me!
Related: https://github.com/github/accessibility-audits/issues/7420, https://github.com/github/accessibility-audits/issues/6706
Utilizes
getGlobalFocusStyles
in ToggleSwitch to override any globaloutline-offset
styles that would apply to it.Changelog
Changed
Applies
outline-offset
viagetGlobalFocusStyles
.Rollout strategy
Testing & Reviewing
Merge checklist