Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ThemeProvider + SSR: Fix incorrect theme with multiple ThemeProviders on page #4477

Merged
merged 3 commits into from
Apr 10, 2024
Merged

ThemeProvider + SSR: Fix incorrect theme with multiple ThemeProviders on page #4477

merged 3 commits into from
Apr 10, 2024

Conversation

siddharthkp
Copy link
Member

@siddharthkp siddharthkp commented Apr 8, 2024 •
edited

Changelog

Add unique id to server handoff to avoid collisions when there are multiple ThemeProvider on one page

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

  • Tested with github/github
  • Tested with github/docs-internal

Merge checklist

@siddharthkp siddharthkp added patch release bug fixes, docs, housekeeping no-breaking-changes: need to test This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Apr 8, 2024
@siddharthkp siddharthkp self-assigned this Apr 8, 2024
@siddharthkp siddharthkp requested a review from a team as a code owner April 8, 2024 14:40
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Apr 8, 2024 •
edited

🦋 Changeset detected

Latest commit: 82df078

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@siddharthkp siddharthkp marked this pull request as draft April 8, 2024 14:40
@siddharthkp siddharthkp removed the request for review from broccolinisoup April 8, 2024 14:40
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 8, 2024 •
edited

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 87.73 KB (+0.06% 🔺)
packages/react/dist/browser.umd.js 88.07 KB (-0.08% 🔽)

@github-actions github-actions bot temporarily deployed to storybook-preview-4477 April 8, 2024 14:46 Inactive
@siddharthkp siddharthkp marked this pull request as ready for review April 9, 2024 14:16
@siddharthkp siddharthkp added no-breaking-changes: confirmed Tested this change doesn't break any existing instances in applications using changed components and removed no-breaking-changes: need to test This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Apr 9, 2024
@siddharthkp siddharthkp added this pull request to the merge queue Apr 10, 2024
Merged via the queue into main with commit 054de02 Apr 10, 2024
35 of 36 checks passed
@siddharthkp siddharthkp deleted the fix-nested-theming-ssr branch April 10, 2024 16:15
@primer primer bot mentioned this pull request Apr 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshblack joshblack joshblack approved these changes

@broccolinisoup broccolinisoup Awaiting requested review from broccolinisoup

Assignees

@siddharthkp siddharthkp

Labels
no-breaking-changes: confirmed Tested this change doesn't break any existing instances in applications using changed components patch release bug fixes, docs, housekeeping
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@siddharthkp @joshblack