[TreeView] Check if the active element is a treeitem

[JelloBagel]

When navigating through the TreeView, the focus should be on the list item. However, when a user clicks on a secondary action inside the list, the user is no longer able to focus back on the list item when navigating to the list. This PR is to fix the focus in TreeView when active element is not a treeitem

Before

1. Navigate through the list with tab.
2. Focus is on the list item (expected)
3. Click on the secondary action
4. Try to navigate to the list
5. Focus is on the secondary action (unexpected)

Screen.Recording.2024-04-09.at.5.50.02.PM.mov

After

1. Click on the secondary action
2. Try to navigate to the list
3. Focus is on the list item

Untitled.mov

Changelog

New

Changed

Ensures the document.activeElement is of role=treeitem before returning focus to the TreeView listitem

Removed

Rollout strategy

• Patch release
• Minor release
• Major release; if selected, include a written rollout or migration plan
• None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

• Added/updated tests
• Added/updated documentation
• Added/updated previews (Storybook)
• Changes are SSR compatible
• Tested in Chrome
• Tested in Firefox
• Tested in Safari
• Tested in Edge
• (GitHub staff only) Integration tests pass at github/github (Learn more about how to run integration tests)

[changeset-bot]

🦋 Changeset detected

Latest commit: b3c1107

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@primer/react	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[github-actions]

size-limit report 📦

Path	Size
packages/react/dist/browser.esm.js	87.98 KB (-0.07% 🔽)
packages/react/dist/browser.umd.js	88.28 KB (-0.1% 🔽)

[siddharthkp]

Hi!

Sorry, I don't understand the before video and how this change would fix it.

Can you please describe what's happening in the video and what should happen after. Thanks!

[JelloBagel]

@siddharthkp I updated the PR description. Let me know if it needs anymore clarification

[siddharthkp]

Thank you adding more context ❤️

Can you also please add a story and test in primer/react so that we don't create a regression in the future, thank you! I'm happy to work on this together if you'd like

[JelloBagel]

@siddharthkp added a story and test in 4df63b8

Screen.Recording.2024-04-19.at.12.24.32.PM.mov

[siddharthkp]

Thank you! ❤️

[siddharthkp]

• Ran integration tests in https://github.com/github/github/pull/322457, only 1 failed test which is unrelated 🎉