Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Donut component #457

Merged
merged 2 commits into from May 22, 2019
Merged

Remove Donut component #457

merged 2 commits into from May 22, 2019

Conversation

emplums
Copy link

@emplums emplums commented May 22, 2019

We've decided to remove the Donut component. It doesn't feel like a general enough component to live in the design system, doesn't exist in Primer CSS, and is inflating our bundle size quite a bit due to it's usage of d3-shape.

Fixes #455

@emplums emplums requested a review from shawnbot May 22, 2019 23:20
@emplums emplums mentioned this pull request May 22, 2019
3 tasks
@emplums emplums changed the base branch from master to release-13.0.0 May 22, 2019 23:22
Copy link
Contributor

@shawnbot shawnbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Goodbye, sweet donut! 😢

@emplums emplums merged commit a34e520 into release-13.0.0 May 22, 2019
@emplums emplums deleted the remove-donut branch May 22, 2019 23:50
@emplums emplums mentioned this pull request May 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants