Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Trigger onClose when Dialog backdrop is clicked (#4565)" #4578

Merged
merged 1 commit into from
May 13, 2024

Conversation

joshblack
Copy link
Member

This reverts commit 564db1d.

This reverts the changes to Dialog closing on backdrop click while we explore the best way to roll this out.

Context in Slack

Changelog

New

Changed

Removed

@joshblack joshblack requested a review from a team as a code owner May 10, 2024 19:12
@joshblack joshblack requested a review from langermank May 10, 2024 19:12
Copy link

changeset-bot bot commented May 10, 2024

⚠️ No Changeset found

Latest commit: 258aa81

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 88.39 KB (+0.03% 🔺)
packages/react/dist/browser.umd.js 88.63 KB (-0.06% 🔽)

@joshblack joshblack added this pull request to the merge queue May 13, 2024
Merged via the queue into main with commit 865f091 May 13, 2024
34 checks passed
@joshblack joshblack deleted the revert-4565-dg/dialog-backdrop-click branch May 13, 2024 15:34
JelloBagel pushed a commit that referenced this pull request May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip changeset This change does not need a changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants