Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(project): update project to use Storybook v8 #4644

Merged
merged 10 commits into from
Jun 11, 2024

Conversation

joshblack
Copy link
Member

Closes https://github.com/github/primer/issues/3299

Update Primer React to use Storybook v8.

Changelog

New

Changed

  • Update dependencies for Storybook by using the storybook cli
  • Update TypeScript errors for missing imports along with new types from Storybook v8

Removed

Rollout strategy

  • None; if selected, include a brief description as to why

This is a change to Storybook and does not impact any packages

Testing & Reviewing

  • View the deploy preview and verify that Storybook renders as expected

Copy link

changeset-bot bot commented Jun 5, 2024

⚠️ No Changeset found

Latest commit: 11510a0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@joshblack joshblack added the skip changeset This change does not need a changelog label Jun 5, 2024
Copy link
Contributor

github-actions bot commented Jun 5, 2024

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 89.45 KB (0%)
packages/react/dist/browser.umd.js 89.79 KB (0%)

@github-actions github-actions bot temporarily deployed to storybook-preview-4644 June 5, 2024 17:23 Inactive
@joshblack joshblack marked this pull request as ready for review June 5, 2024 17:24
@joshblack joshblack requested a review from a team as a code owner June 5, 2024 17:24
Copy link
Member

@broccolinisoup broccolinisoup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much!! Looks great!

@joshblack joshblack enabled auto-merge June 11, 2024 14:19
@joshblack joshblack added this pull request to the merge queue Jun 11, 2024
Merged via the queue into main with commit 5c05236 Jun 11, 2024
30 checks passed
@joshblack joshblack deleted the refactor/update-to-storybook-v8-take-2 branch June 11, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip changeset This change does not need a changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants