Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Utilize aria-describedby on all ActionList descriptions #4666

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

TylerJDev
Copy link
Contributor

@TylerJDev TylerJDev commented Jun 11, 2024

Closes https://github.com/github/primer/issues/2501

Changelog

Changed

  • Added aria-describedby to inline description
  • Added aria-labelledby to ActionList.TrailingVisual

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

Copy link

changeset-bot bot commented Jun 11, 2024

🦋 Changeset detected

Latest commit: 69a57f1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Jun 11, 2024

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 90.82 KB (-0.01% 🔽)
packages/react/dist/browser.umd.js 91.15 KB (+0.07% 🔺)

@TylerJDev TylerJDev marked this pull request as ready for review June 12, 2024 17:12
@TylerJDev TylerJDev requested a review from a team as a code owner June 12, 2024 17:12
@TylerJDev TylerJDev requested a review from camertron June 12, 2024 17:12
@github-actions github-actions bot temporarily deployed to storybook-preview-4666 June 12, 2024 17:16 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant