-
Notifications
You must be signed in to change notification settings - Fork 528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SelectPanel: Update SelectPanel to use modern ActionList #4794
base: main
Are you sure you want to change the base?
Conversation
|
size-limit report 📦
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, nice work! As far as groups go, it looks like both the beta and deprecated versions of ActionList
support them. Maybe we could create a sub-component called MappedActionListGroup
? Then we could do something like:
function MappedActionListGroup({ items, header }: GroupProps) {
return (
<ActionList.Group>
<ActionList.GroupHeading variant={header.variant}>
{header.title}
</ActionList.GroupHeading>
{items.map((item) => <MappedActionList item={item}>)}
</ActionList.Group>
)
}
text, | ||
variant, | ||
disabled, | ||
trailingVisual: TrailingVisual, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if this is a common pattern, but I personally find it a bit confusing to use TitleCase for these renamed variables. Can we avoid renaming them, or name them something else, eg. originalTrailingVisual
?
👋 Hi from github/github! Your integration PR is ready: https://github.com/github/github/pull/337077 |
Closes #
Changelog
New
Changed
Removed
Rollout strategy
Testing & Reviewing
Merge checklist