Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to Actions v2 #543

Merged
merged 3 commits into from
Sep 18, 2019
Merged

Migrate to Actions v2 #543

merged 3 commits into from
Sep 18, 2019

Conversation

smockle
Copy link
Member

@smockle smockle commented Sep 16, 2019

Migrates from GitHub Actions v1 to Actions v2.

Rationale:

  • The documentation now presupposes Actions v2 usage
  • The “Workflows defined in .github/workflows” link in the “Actions” tab is currently broken (screenshot below):

workflows-link

Changes:

@vercel
Copy link

vercel bot commented Sep 16, 2019

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

@vercel vercel bot temporarily deployed to staging September 16, 2019 19:06 Inactive
@vercel vercel bot temporarily deployed to staging September 16, 2019 19:09 Inactive
@vercel vercel bot temporarily deployed to staging September 16, 2019 19:10 Inactive
@vercel vercel bot temporarily deployed to staging September 16, 2019 19:17 Inactive
@vercel vercel bot temporarily deployed to staging September 16, 2019 19:34 Inactive
@vercel vercel bot temporarily deployed to staging September 16, 2019 19:44 Inactive
@vercel vercel bot temporarily deployed to staging September 16, 2019 19:54 Inactive
@vercel vercel bot temporarily deployed to staging September 16, 2019 21:06 Inactive
@vercel vercel bot temporarily deployed to staging September 18, 2019 15:11 Inactive
@vercel vercel bot temporarily deployed to staging September 18, 2019 15:15 Inactive
@smockle smockle changed the title [WIP] Migrate to Actions v2 Migrate to Actions v2 Sep 18, 2019
@smockle
Copy link
Member Author

smockle commented Sep 18, 2019

To eliminate future merge conflicts, I’d originally attempted to incorporate the changes in #450 into this PR. But I was stumped by 401s during attempts to publish to GPR, e.g. https://github.com/primer/components/commit/409e586758051b62243b677ed7d715ccabf52236/checks. I spent some time debugging, then decided to keep this PR small and focused on the migration to Actions v2.

Copy link

@emplums emplums left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just left one request for changes! Thank you for doing this, I've been meaning to get around to it! 🎉

.github/workflows/main.yml Outdated Show resolved Hide resolved
@emplums
Copy link

emplums commented Sep 18, 2019

I'm not super worried about keeping the publish to GPR stuff - we can circle back on that later and re-set it up! It didn't take too long and that PR is pretty stale so we might as well start fresh :)

@vercel vercel bot temporarily deployed to staging September 18, 2019 15:46 Inactive
Copy link

@emplums emplums left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 🎉

@smockle smockle merged commit 889c0a6 into master Sep 18, 2019
@smockle smockle deleted the actions-v2 branch September 18, 2019 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants