Migrate StyledOcticon to TypeScript #993
Conversation
🦋 Changeset detectedLatest commit: f06e9a6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/primer/primer-components/l7u2037wn |
| @@ -15,10 +15,6 @@ describe('StyledOcticon', () => { | |||
| default: StyledOcticon | |||
| }) | |||
|
|
|||
| it('implements system props', () => { | |||
| expect(StyledOcticon).toImplementSystemProps(COMMON) | |||
| }) | |||
There was a problem hiding this comment.
This test is run in the behavesAsComponent() test helper.
| icon: PropTypes.any.isRequired, | ||
| size: PropTypes.any, |
There was a problem hiding this comment.
These propTypes were causing errors. Since we'll be removing propTypes soon, I think any is fine for now.
There was a problem hiding this comment.
I’d personally go ahead and remove PropTypes from this file, but this is fine too!
This PR migrates the
StyledOcticoncomponent to TypeScript as part of the TypeScript refactor.