Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gitignore version manager files #1194

Merged
merged 2 commits into from Jun 16, 2022
Merged

Conversation

camertron
Copy link
Contributor

I propose we gitignore .ruby-version and .tool-versions, files used by Ruby version managers. Generally speaking, development is done in codespaces these days, which already have the correct Ruby version installed. Moreover, the existence of .ruby-version confuses the bin/vendor-gem script in dotcom.

@changeset-bot
Copy link

changeset-bot bot commented Jun 10, 2022

🦋 Changeset detected

Latest commit: 120ea4a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/view-components Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@camertron camertron temporarily deployed to github-pages June 10, 2022 21:41 Inactive
@camertron camertron marked this pull request as ready for review June 10, 2022 21:41
@camertron camertron requested review from a team, hectahertz and joelhawksley June 10, 2022 21:41
Copy link
Contributor

@langermank langermank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good I think? 😄

Copy link
Member

@jonrohan jonrohan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's a good idea 👍🏻

@camertron camertron merged commit 568f312 into main Jun 16, 2022
@camertron camertron deleted the gitignore_version_manager_files branch June 16, 2022 17:14
@primer-css primer-css mentioned this pull request Jun 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants