Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert StateComponent to support functional colors internally #269
Convert StateComponent to support functional colors internally #269
Changes from 22 commits
a50ec01
716727e
ea20ac7
09e5daa
b5bcc03
54cd3b3
ba0cfda
cb823cc
83ab0c5
34bdd0f
f9d6b01
ce30e41
17f29d2
310a95f
7f5083c
c6447e8
7261a3e
d0ff791
b42dcd4
35dc6b0
88cb854
b01f4d3
fbd9a43
3d24d3f
546e933
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a little odd to have this argument named
color
, as that's also a system argument. But perhaps that's a concern for another time 😄There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is part of the conversation about splitting
system_arguments
into different things