Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add subtitle slot to the Primer::Alpha::Overlay::Header and Primer::Alpha::Dialog::Header #2808

Merged
merged 7 commits into from Apr 26, 2024

Conversation

kendallgassner
Copy link
Contributor

What are you trying to accomplish?

I would like to add a link inside of a subtitle. In order to do this I need the subtitle field to be a slot.

Screenshots

Integration

List the issues that this change affects.

Closes # (type the GitHub issue number after #)

Risk Assessment

  • Low risk the change is small, highly observable, and easily rolled back.
  • Medium risk changes that are isolated, reduced in scope or could impact few users. The change will not impact library availability.
  • High risk changes are those that could impact customers and SLOs, low or no test coverage, low observability, or slow to rollback.

What approach did you choose and why?

Anything you want to highlight for special attention from reviewers?

Accessibility

  • Fixes axe scan violation - This change fixes an existing axe scan violation.
  • No new axe scan violation - This change does not introduce any new axe scan violations.
  • New axe violation - This change introduces a new axe scan violation. Please describe why the violation cannot be resolved below.

Merge checklist

  • Added/updated tests
  • Added/updated documentation
  • Added/updated previews (Lookbook)
  • Tested in Chrome
  • Tested in Firefox
  • Tested in Safari
  • Tested in Edge

Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.

@kendallgassner kendallgassner requested a review from a team as a code owner April 26, 2024 17:41
Copy link

changeset-bot bot commented Apr 26, 2024

🦋 Changeset detected

Latest commit: 44e33d9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/view-components Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

@camertron camertron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind adding the same slot to the Dialog header so the APIs are consistent?

@kendallgassner kendallgassner changed the title Add subtitle slot to the Primer::Alpha::Overlay::Header Add subtitle slot to the Primer::Alpha::Overlay::Header and Primer::Alpha::Dialog::Header Apr 26, 2024
@kendallgassner
Copy link
Contributor Author

kendallgassner commented Apr 26, 2024

@camertron can you merge this 🙏 . I don't have merge access.

@camertron camertron merged commit bdb3d88 into main Apr 26, 2024
10 of 12 checks passed
@camertron camertron deleted the add_subtitle_slot branch April 26, 2024 19:51
@primer primer bot mentioned this pull request Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants